Attention List #4

						
				@@ -0,0 +58,4 @@

				    parser = argparse.ArgumentParser(

				        description='Bootstrap repositories.')

				    parser.add_argument(

				        '--gh-orgs',

gtema commented

2022-09-28 10:06:40 +00:00

actually instead of that I was expecting rather going through current metadata analyzing only repositories that we care about (smth like in any other script). Please adapt to to consume metadata and rather take parameters “environment” which is then set in the metadata

actually instead of that I was expecting rather going through current metadata analyzing only repositories that we care about (smth like in any other script). Please adapt to to consume metadata and rather take parameters "environment" which is then set in the metadata

Ghost commented

2022-09-28 13:16:01 +00:00

we added the option to provide the token as metadata. Do you think the other stuff should also be added there or what did you mean?

Regarding the git sources: We build the script to use it as a general tool. If it should gather the data from metadata, we will do this or try to do this.

we added the option to provide the token as metadata. Do you think the other stuff should also be added there or what did you mean? Regarding the git sources: We build the script to use it as a general tool. If it should gather the data from metadata, we will do this or try to do this.

tools/attention_list.py Outdated

						
				@@ -0,0 +117,4 @@

				    while True:

				        try:

				            req_url = (url

gtema commented

2022-09-28 10:09:02 +00:00

you can either use existing SDK or at least make a wrapper for requests so that you do not repeat the same exception handling block over and over again (smth like in https://review.opendev.org/c/zuul/zuul/+/850008/10/zuul/driver/gitea/giteaconnection.py#364 or in https://github.com/opentelekomcloud/ansible-collection-gitcontrol/tree/main/plugins/module_utils)

tools/attention_list.py Outdated

						
				@@ -0,0 +157,4 @@

				        exit()

				    return pullrequests

				def get_failed_gitea_commits(pull, url, gitea_org, repo, headers):

gtema commented

2022-09-28 10:09:46 +00:00

pls decide on function naming convention, get_gitea_failed_commits fits more other functions

Ghost commented

2022-09-28 13:13:33 +00:00

done

tools/attention_list.py Outdated

						
				@@ -0,0 +386,4 @@

				                            )

				                            failed_commits.extend(commits)

				    print(create_json_result(