infra/otc-metadata
14
0
Fork 13
Code Issues 5 Pull Requests Packages Releases Wiki Activity

Set environment for SBV internally automatically to internal #238

Merged
zuul merged 1 commits from sbv-update into main 2024-07-23 06:58:33 +00:00
Conversation 4 Commits 1 Files Changed 2 +2
2 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
otc_metadata/templates/index_sbv.rst.j2
View File

@ -5,3 +5,4 @@
.. service_card::
:service_type: {{ service_type }}
:environment: {{ environment }}

1
tools/generate_doc_confpy.py
View File

@ -201,6 +201,7 @@ def process_repositories(args, service):
site_name="Internal Documentation Portal",
logo_url="https://docs-int.otc-service.com",
)
context["environment"] = args.target_environment
sgode marked this conversation as resolved
vhasko commented 2024-07-16 12:55:38 +00:00
Review
Copy Link

maybe move it under if args.target_environment == “internal” condition as we normally add this only for internal environment.

in this place it where it is now would add it also for public environment.

maybe move it under if args.target_environment == "internal" condition as we normally add this only for internal environment. in this place it where it is now would add it also for public environment.
sbv_title = (service["service_title"] + "\n"
+ ('=' * len(service["service_title"])))
context["sbv_title"] = sbv_title