infra/otc-metadata
15
0
Fork 13
Code Issues 5 Pull Requests Packages Releases Wiki Activity

removed environment: internal for ocr #204

Merged
zuul merged 3 commits from (deleted):ocr_public_release into main 2024-04-02 15:25:27 +00:00
Conversation 8 Commits 3 Files Changed 3
+1 -3
vpruthi commented 2024-04-02 09:15:34 +00:00
Contributor
Copy Link
Copy Source
vpruthi added 1 commit 2024-04-02 09:15:34 +00:00
removed environment: internal for ocr
gl/check check status: success (b56b7c349352d9fd52b5ac71bc3a8dafb80f9871)
Details
b56b7c3493
zuul commented 2024-04-02 09:23:02 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/a09dc1898f1e4eb2b6a046ff0453e498

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/a09dc1898f1e4eb2b6a046ff0453e498 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/37d4667400ae444d8938569d1292fba3): SUCCESS in 4m 45s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/f9e7e2ed51cf4a89afc8e085e94f0a59): SUCCESS in 7m 01s
vpruthi requested review from vhasko 2024-04-02 10:20:48 +00:00
vpruthi requested review from sgode 2024-04-02 10:21:24 +00:00
sgode approved these changes 2024-04-02 10:23:31 +00:00
sgode requested changes 2024-04-02 10:26:52 +00:00
sgode left a comment
Owner
Copy Link
Copy Source

fails on docsportal build

fails on docsportal build
sgode reviewed 2024-04-02 10:27:57 +00:00
otc_metadata/data/services/ocr.yaml Outdated
@@ -1,5 +1,4 @@
---
environment: internal
sgode commented 2024-04-02 10:27:57 +00:00
Owner
Copy Link
Copy Source

Please don’t remove that but change it to public, we need this var. Changing it all to public is the better way to do it, but we only really require it on the service-level.

You can try building docsportal afterwards to see whether it works.

Please don't remove that but change it to `public`, we need this var. Changing it all to `public` is the better way to do it, but we only really require it on the service-level. You can try building docsportal afterwards to see whether it works.
vpruthi commented 2024-04-02 11:22:00 +00:00
Author
Contributor
Copy Link
Copy Source

Thank you @sgode for your feedback, added back environment: public on service-level to ocr.yaml

Thank you @sgode for your feedback, added back environment: public on service-level to ocr.yaml
vpruthi marked this conversation as resolved
vpruthi added 1 commit 2024-04-02 11:20:34 +00:00
added environment: public for ocr
gl/check check status: pending (e54ee01c7a6587119e4a0e4a18a3410ae1f97390)
Details
e54ee01c7a
vpruthi requested review from sgode 2024-04-02 11:22:12 +00:00
vpruthi added 1 commit 2024-04-02 11:23:54 +00:00
added environment: public for ocr
gl/check check status: success (044cd16203c852c650adcf047fc5b622403fb3b5)
Details
gl/gate gate status: success (044cd16203c852c650adcf047fc5b622403fb3b5)
Details
044cd16203
sgode approved these changes 2024-04-02 11:27:48 +00:00
sgode left a comment
Owner
Copy Link
Copy Source

Now everything works :)

Now everything works :)
👍 1
zuul commented 2024-04-02 11:30:12 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/2cadb0406cc94fae936c12dbbbf8c454

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/2cadb0406cc94fae936c12dbbbf8c454 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/3030cd308fe84c8289df00fa84dc72c9): SUCCESS in 5m 59s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/60a04e4bf29f43aa8b512c9934ea8025): SUCCESS in 5m 49s
vhasko approved these changes 2024-04-02 15:18:46 +00:00
vhasko added the gate label 2024-04-02 15:19:02 +00:00
zuul commented 2024-04-02 15:25:26 +00:00
Member
Copy Link
Copy Source

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/822ce049e19a41e78e2ac829b63e230e

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/822ce049e19a41e78e2ac829b63e230e - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/390c989c0ef34d5b82e3a298060e781c): SUCCESS in 5m 58s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/0115ece967be41b88e13d1dc34e3e0ed): SUCCESS in 5m 39s
zuul merged commit be8fad03bc into main 2024-04-02 15:25:27 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
sgode
vhasko
Labels
Clear labels
gate
Gate it
gate
Gate it
No labels gate
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 (Lukas Cuper,) akyriako (Akriotis, Kyriakos) ansideln (Sidelnikov, Anton) cicd eod ikvrivis (Kvrivishvili, Iustina) otcbot proposalbot sgode (Gode, Sebastian) smartyno (Martynov, Sergei) tischrei (Tino Schreiber) vhasko (Hasko, Vladimir) vladimirhasko zuul zuul-ci
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#204