infra/otc-metadata
14
0
Fork 13
Code Issues 5 Pull Requests Packages Releases Wiki Activity

Additions to sbv confpy #123

Merged
zuul merged 2 commits from search_suggested_sbv into main 2023-07-27 12:28:44 +00:00
Conversation 5 Commits 2 Files Changed 1 +2
sgode commented 2023-07-24 09:39:03 +00:00
Owner
Copy Link

Result will look like this: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py

Result will look like this: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py
sgode added 1 commit 2023-07-24 09:39:03 +00:00
Additons to sbv confpy
All checks were successful
gl/check check status: success (b845ddd42e5ec5003425171b0373ffa01d6e506a)
Details
b845ddd42e
sgode requested review from vhasko 2023-07-24 09:40:15 +00:00
zuul commented 2023-07-24 09:41:59 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/0ecd4219003c47089ab683ba7aa511fb

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/0ecd4219003c47089ab683ba7aa511fb - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/e790d88b66f14030b6843d4def9c1c0d): SUCCESS in 2m 12s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/bf041e3b7a554c94beebbf06a5efd8a6): SUCCESS in 2m 29s
vhasko reviewed 2023-07-25 19:38:58 +00:00
tools/generate_doc_confpy.py Outdated
@ -186,1 +186,4 @@
)
context["service_category"] = service['service_category']
context["service_title"] = service['service_title']
context["service_type"] = service['service_type']
vhasko commented 2023-07-25 19:38:58 +00:00
Owner
Copy Link

service_type is already present in context by previous context = dict(…) assignment why service_title is required if in context there’s already title key?

service_type is already present in context by previous context = dict(...) assignment why service_title is required if in context there's already title key?
sgode commented 2023-07-27 12:07:00 +00:00
Author
Owner
Copy Link

service_type is already present in context by previous context = dict(…) assignment why service_title is required if in context there’s already title key?

The title includes the - Service Based View which results in that: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py#L101 However having the actual title of the service as data is needed for the search stuff. I’m not sure whether we use the title somewhere, so I’m not sure if simply removing the - Service Based View thingy would break anything. Generally that would work, but then SBV would be the only thing not having the service_title attribute.

> service_type is already present in context by previous context = dict(...) assignment > why service_title is required if in context there's already title key? > > The title includes the `- Service Based View` which results in that: https://gitea.eco.tsi-dev.otc-service.com/docs/elastic-cloud-server/src/branch/test-search-4/doc/source/conf.py#L101 However having the actual title of the service as data is needed for the search stuff. I'm not sure whether we use the title somewhere, so I'm not sure if simply removing the `- Service Based View` thingy would break anything. Generally that would work, but then SBV would be the only thing not having the service_title attribute.
sgode added 1 commit 2023-07-27 12:09:19 +00:00
Removed double type
All checks were successful
gl/check check status: success (f56b5373a0d50c5c88e34d4f59700382d23bb94b)
Details
gl/gate gate status: success (f56b5373a0d50c5c88e34d4f59700382d23bb94b)
Details
f56b5373a0
zuul commented 2023-07-27 12:12:37 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/1de9033e91bf4d8ebab7ec47c0b16dcc

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/1de9033e91bf4d8ebab7ec47c0b16dcc - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/03605b1007c5496abdd3d80ba80cc784): SUCCESS in 2m 14s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/5e2f19d9af0643248d478149ea9b04e0): SUCCESS in 2m 49s
vhasko approved these changes 2023-07-27 12:25:21 +00:00
sgode added the
gate
 label 2023-07-27 12:25:56 +00:00
zuul commented 2023-07-27 12:28:43 +00:00
Member
Copy Link

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/0beed09a0ec844efa3bad3a068e38f49

Build succeeded. https://zuul.otc-service.com/t/gl/buildset/0beed09a0ec844efa3bad3a068e38f49 - [otc-tox-pep8 ](https://zuul.otc-service.com/t/gl/build/c651b46fce4441cc8b44a870c19114ff): SUCCESS in 2m 07s - [otc-tox-py39 ](https://zuul.otc-service.com/t/gl/build/1cf67612691640fd82177cc3d613c168): SUCCESS in 2m 23s
zuul merged commit 370bf69636 into main 2023-07-27 12:28:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
vhasko
Labels
Clear labels
gate
Gate it
gate
Gate it
No Label
gate
Milestone
No items
No Milestone
Assignees
Clear assignees
A200014817 ansideln cicd ikvrivis magnus otcbot proposalbot sgode smartyno tischrei vhasko vladimirhasko zuul
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: infra/otc-metadata#123
No description provided.
Delete Branch "search_suggested_sbv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?